Update the adapter binaries cargo-component uses #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in a fix for bytecodealliance/wasmtime#10058
sunfishcode
approved these changes
Jan 21, 2025
|
The CI failure looks like it's due to the fact that the updated adapter has WASI 0.2.3 as the version where it previously had WASI 0.2.0. The version of Wasmtime used in CI wasn't old enough to have the forward-compatibility fix (CI used 22, the fix was in 23). I've confirmed that Wasmtime 23, as expected, works well with the new adapter. I've gone ahead and pushed a commit that updates the version used in CI to Wasmtime 29.0.1 as well, the current latest release of Wasmtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a fix for bytecodealliance/wasmtime#10058