Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: Optionalize wasm-opt crate dependency #63

Merged
merged 2 commits into from
Jun 19, 2024
Merged

dep: Optionalize wasm-opt crate dependency #63

merged 2 commits into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. dep: Optionalize wasm-opt crate dependency 

    The `wasm-opt` crate brings in C++ dependencies (binaryen) and it makes
the build process more complex and slower (also setting up
cross-compilation for C++ is not trivial unlike Rust).
Also the DCE process doesn't make much difference if we allow all WASI
subsystems.
This commit makes the `wasm-opt` crate dependency optional so that crate
users can choose whether to use it or not.

Also strip the "name" section at walrus module generation time if
`debug=false` because it was stripped by `wasm-opt` before.
    @kateinoigakukun
    kateinoigakukun committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c1dc925 View commit details
    Browse the repository at this point in the history

  2. ci: Add a job to test without default features

    @kateinoigakukun
    kateinoigakukun committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8772e0f View commit details
    Browse the repository at this point in the history