chore: remove use of nightly features in Cargo.toml #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/no-nightly-in-cargo-toml
branch
from
d6bf35f
to
73d2945
Compare
|
Thank you! Can we also update the readme to remove the nightly mention then? |
The use of `profile-rustflags` is mainly to minimize the size of virtual-adapter, but it's declared in the root Cargo.toml since it's only allowed in the workspace root even though it's not used when building wasi-virt crate. The use of the nightly feature requires projects depending on wasi-virt crate to also use nightly, which complicates the build process (especially building native extensions of Ruby..) This commit moves the `rustflags` setting from the Cargo.toml to the RUSTFLAGS env var in build-adapter.sh.
kateinoigakukun
force-pushed
the
katei/no-nightly-in-cargo-toml
branch
from
73d2945
to
bf0fb09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
profile-rustflagsis mainly to minimize the size of virtual-adapter, but it's declared in the root Cargo.toml since it's only allowed in the workspace root even though it's not used when building wasi-virt crate.The use of the nightly feature requires projects depending on wasi-virt crate to also use nightly, which complicates the build process (especially building native extensions of Ruby..)
This commit moves the
rustflagssetting from the Cargo.toml to the RUSTFLAGS env var in build-adapter.sh.