Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to wasi-cli 0.2.0-rc-2023-12-05 snapshot #41

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

whitequark
Copy link
Contributor

@whitequark whitequark commented Jan 21, 2024

This was both surprisingly easy and surprisingly tedious.

I've tested this on Yosys; clocks, environment, stdio, and filesystem (including virtualized mount) all work great. I've never used WASI networking so everything related to it remain as-is, but a cursory check suggests to me that that's probably OK.

Fixes #37.

@whitequark whitequark force-pushed the wasi-2023-12-05 branch 2 times, most recently from 1dc4673 to 221e1d0 Compare January 21, 2024 02:47
@whitequark whitequark force-pushed the wasi-2023-12-05 branch 3 times, most recently from b2777cd to d461693 Compare January 21, 2024 04:30
@sunfishcode
Copy link
Member

This looks good to me!

With the Wasmtime update, we'll also want to update wasi-http to the version in Wasmtime, but it has more changes and I'm already working on that in another tree, so I'll take care of that in a follow-up.

@whitequark
Copy link
Contributor Author

Thanks! With this I should be able to migrate YoWASP to WASI-Virt and remove quite a lot of manually written resource loading code. I'm really looking forward to that!

Do you know if WASI-Virt is going to be integrated with JCO? That would make it easier to use from my CI scripts.

@guybedford
Copy link
Collaborator

Thanks @whitequark for your work here! I would actually quite like to introduce a jco virt alias for WASI-Virt in JCO, as the project is a JS component toolchain more generally, hoping to get to that but happy to take any PRs in that direction too.

@whitequark
Copy link
Contributor Author

I would actually quite like to introduce a jco virt alias for WASI-Virt in JCO, as the project is a JS component toolchain more generally

I have my hands quite full but if you do introduce this I will deploy it right away in YoWASP.

@sunfishcode sunfishcode merged commit 96392a7 into bytecodealliance:main Jan 22, 2024
2 checks passed
@whitequark whitequark deleted the wasi-2023-12-05 branch May 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASI wits are outdated
3 participants