-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch Fixes #49
Fetch Fixes #49
Conversation
It looks like #52 may now resolve this I believe. |
Hi @nicoburniske, as Guy said, #52, which I've been working on for quite a while, should address these same issues, plus a whole host of others. my apologies for not highlighting that work more thoroughly earlier, and hence causing you to do a bunch of duplicate work :( |
@tschneidereit No problem whatsoever. I'm just happy it's being addressed! Thanks for all of your hard work on this |
Closing in favor of #52 |
Closes #10, #19
Fix GET and POST request bugs:
HttpOutgoingRequest
and close body inwrite_all
caseNote: Async body in POST requests is not supported. This means when you make a fetch request and pass the response body directly into another fetch request without awaiting it first, like:
This limitation should be documented and addressed separately from the fixes in this PR.