Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure filename is defined for builtins in debug builds #166

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: ensure filename is defined for builtins in debug builds #166

merged 1 commit into from
Oct 30, 2024

Conversation

guybedford
Copy link
Contributor

This fixes a bug where filename on CompileOptions was not being set for builtin modules in the script loader, which was fine on release builds but failing on debug builds.

tschneidereit
tschneidereit approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and sorry for not catching that. I assume a test isn't trivial to write for this?

@guybedford guybedford merged commit 3d85982 into main Oct 30, 2024
5 checks passed
@guybedford guybedford deleted the debug-fix branch October 30, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschneidereit tschneidereit tschneidereit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @tschneidereit