Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor step 1: remove _utily.py #91

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Refactor step 1: remove _utily.py #91

wants to merge 35 commits into from

Conversation

cgahr
Copy link
Collaborator

@cgahr cgahr commented May 1, 2023 •
edited
Loading

Depends on #84
See #92 for the discussion

This was referenced May 1, 2023
Open
Closed
Constantin Gahr added 28 commits May 5, 2023 15:30
introduce Config class, that parses pyproject.toml and iterates over …
28e98a1 
…all valid python files
remove redundant find_python_files code, add find_project_root
4015253
use new config to iterate over python files
e22fd32
remove unnecessary error handling, both are handled by config.files()
51f1b1e
add config for ssort
76f8171
update tests for _files.py
36a791b
fix bug find_project_root
4719570
use tomli for python < 3.11, tomlib for python >= 3.11
ad0c19a
add tomli dependency
2f45861
remove pathspec mypy block since pathspec is not longer needed
eb478e5
remove test to check for not existent file, this cannot happen anymore
60348f1
mock find_project_root so that pytest does not search for pyproject.t…
6106a21 
…oml beyond the specified test-folder
ssort only sorts the inteded files, not all files under root
0ced832
Revert "remove unnecessary error handling, both are handled by config…
ae5727e 
….files()"

This reverts commit 193af08.
Revert "remove test to check for not existent file, this cannot happe…
ac0c4e3 
…n anymore"

This reverts commit 674ef12.
non existent and no py files are now handled by the config class and …
4d5301e 
…dont create an error msg
FileNotFoundError case handled by config
ad42a0b
path is directory is handled by dir iterator of config
3a56772
add tests for config
f08581d
define pytest test path in pyproject.toml
9917510
sync tox.ini and ci.yaml
6b08488
export only get_config_from_root using __all__
5323923
fix import statement to mirror the others
4d8e81b
add current working dir to find_project_root to find the expected pyp…
d7c7cce 
…roject.toml
add skip_glob configuration key to filter files with glob pattern
33d455f
add tests for Config.is_invalid
4641a52
fix a bug where glob pattern was incorrectly applied if path was not …
f91b0d4 
…a file
create current_working_dir to make testing easier, add more tests
b11811a
@cgahr cgahr force-pushed the refactor-step-1 branch from 27ec33e to 44ee98a Compare May 5, 2023 13:32
@bwhmather
Copy link
Owner

(I'm temporarily ignoring this until the PR it sits on is out of the way. Not opposed to the idea in principle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgahr @bwhmather