-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to disable non default signature algorithm(s) #5
base: master
Are you sure you want to change the base?
Conversation
Ability to disable non default signature algorithm
# are disabled. This is useful if you only want to support one algorithm. | ||
# NOTE: if true, you can still verify validity of timestamps generated with | ||
# any other supported algorithm for the keys listed in otherTrustedPublicKeys | ||
disableOtherSigAlg: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This presumes that either there only will be two signature algorithms supported or that you'd only want to enable one of them. It seems more logical to me to have an option enabledSigAlgs
, and then perhaps interpret the first as the default.
Why do you want to disable one of them btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently Yivi is creating a PoC moving the infrastructure into a cloud agnostic environment. Since we are only using ed25519 and we need atumd to be stateless, this small change is (for us) the least intrusive way to make that happen. No change in config needed to keep the current situation running while it is possible to disable all other algorithms (for now only XMSS[MT]) except the default one in our cloud setup.
Thought this could be a nice addition in functionality, hence the pr. On the other hand I also agree with you that the other way around with an option like enabledSigAlgs
would be a nice approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm!
…k-on-Ed25519KeyPath relax file permission check on Ed25519KeyPath
…k-on-Ed25519KeyPath fileInfo declared and not used
This modification adds an extra boolean configuration variable
disableOtherSigAlg
that allows you to disable all signature algorithms other than the specifieddefaultSigAlg
.If for example
defaultSigAlg
is set toed25519
anddisableOtherSigAlg=true
it will not be possible to generate a timestamp based on XMSS[MT]. Also (automatic) XMSS[MT] key generation at startup will not happen in this case, essentially disabling all XMSS[MT] based functionality.There is one exception: it will always be possible to verify timestamps for all supported algorithms. So in a scenario where XMSS[MT] is used as algorithm and server config is changed to only accept Ed25519 from now on, it is still possible to validate XMSS[MT] timestamps as long as the public key is listed in
otherTrustedPublicKeys
.