Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Commit

Permalink
Merge pull request #35 from buttercup/sallar/theme-fixes
Browse files Browse the repository at this point in the history
Fix theme issues for Desktop
  • Loading branch information
perry-mitchell authored Jan 10, 2021
2 parents f0a2aca + 3aa52b5 commit e8f135a
Show file tree
Hide file tree
Showing 6 changed files with 65 additions and 48 deletions.
96 changes: 55 additions & 41 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"styled-components": "^4.1.3"
},
"dependencies": {
"@blueprintjs/core": "^3.25.0",
"@blueprintjs/core": "^3.36.0",
"@blueprintjs/icons": "^3.15.0",
"@buttercup/generator": "^1.2.0",
"@buttercup/react-formatted-input": "^1.3.0",
Expand Down
3 changes: 2 additions & 1 deletion src/components/vault/AddEntry.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ const AddEntry = ({ disabled }) => {
text="New Entry"
onClick={() => onAddEntry(defaultEntryType)}
disabled={disabled}
fill
/>
<Popover content={renderMenu} boundary="viewport">
<Button icon="more" disabled={disabled} />
<Button icon="more" disabled={disabled} fill={false} />
</Popover>
</ButtonGroup>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/vault/Pane.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const PaneContainer = styled.div`
display: grid;
overflow: hidden;
background-color: ${props => props.primary && getThemeProp(props, 'colors.mainPaneBackground')};
grid-template-rows: 55px 1fr 40px;
grid-template-rows: 55px 1fr 50px;
grid-template-areas:
'header'
'body'
Expand Down
2 changes: 2 additions & 0 deletions src/styles/themes.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Colors } from '@blueprintjs/core';

const light = {
dark: false,
vault: {
list: {
focusedBackgroundColor: Colors.LIGHT_GRAY5,
Expand Down Expand Up @@ -34,6 +35,7 @@ const light = {
};

const dark = {
dark: true,
vault: {
list: {
focusedBackgroundColor: Colors.DARK_GRAY5,
Expand Down
8 changes: 4 additions & 4 deletions stories/vault.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ function VaultRender({ formatB = false, dark = false, basic = true, icons = true
createVaultManager();
}, []);
return (
<ThemeProvider theme={dark ? themes.dark : themes.light}>
<View>
<View className={dark ? 'bp3-dark' : ''}>
<ThemeProvider theme={dark ? themes.dark : themes.light}>
<If condition={archiveFacade}>
<VaultProvider
vault={archiveFacade}
Expand Down Expand Up @@ -289,8 +289,8 @@ function VaultRender({ formatB = false, dark = false, basic = true, icons = true
<VaultUI />
</VaultProvider>
</If>
</View>
</ThemeProvider>
</ThemeProvider>
</View>
);
}

Expand Down

0 comments on commit e8f135a

Please sign in to comment.