launch/policy: fix misallocations and leaks with invalid uids/gids #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When records are imported, but never linked to any policy list, we currently leak the records. Fix this and properly deallocate the records in those cases. Note that this only happens when invalid uids/gids are specified, which is not common for production systems. Reported-by: Evgeny Vereshchagin <[email protected]> Reported-by: Frantisek Sumsal <[email protected]> Signed-off-by: David Rheinsberg <[email protected]>
Invalid groups/users are reported as `-1` by the config parser, and generally ignored by the policy import. Unfortunately, the own-policy importer does not check for it when importing into groups. Fix this and align it with `policy_import_send/recv`. Signed-off-by: David Rheinsberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes related to policy imports with invalid uids/gids.
Initial report was in #360.