bus/match: fix matching against arguments beyond the zeroth #369
+208
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367. I hit this too, also for JobRemoved signals, and @dvdhrm pinpointed the fix, so here it is.
I added both white-box and black-box tests. The former are copies of the arg0 tests changed to match arg1. The latter include negative tests (signals that should not be matched), which aren't present in the existing tests, but seem useful. I didn't run the black-box tests against dbus-daemon because I don't see how. I put the tests in the same commit as the fix based on looking at old commits in this repo, but they can be separate if you'd prefer.
@TomasKorbar I gave you Reported-by: under your Red Hat e-mail (based on recent commits in other repos). Let me know if this should be under a personal e-mail instead or just omitted.
@dvdhrm You can add Co-developed-by: yourself if you want, as you did find the fix.