Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bus/match: fix matching against arguments beyond the zeroth #369

Closed
wants to merge 1 commit into from

Conversation

jbosboom
Copy link
Contributor

@jbosboom jbosboom commented Jul 9, 2024

Fixes #367. I hit this too, also for JobRemoved signals, and @dvdhrm pinpointed the fix, so here it is.

I added both white-box and black-box tests. The former are copies of the arg0 tests changed to match arg1. The latter include negative tests (signals that should not be matched), which aren't present in the existing tests, but seem useful. I didn't run the black-box tests against dbus-daemon because I don't see how. I put the tests in the same commit as the fix based on looking at old commits in this repo, but they can be separate if you'd prefer.

@TomasKorbar I gave you Reported-by: under your Red Hat e-mail (based on recent commits in other repos). Let me know if this should be under a personal e-mail instead or just omitted.

@dvdhrm You can add Co-developed-by: yourself if you want, as you did find the fix.

Reported-by: Tomas Korbar <[email protected]>
Signed-off-by: Jeffrey Bosboom <[email protected]>
@TomasKorbar
Copy link

@jbosboom Red Hat mail is fine.

@dvdhrm dvdhrm mentioned this pull request Jul 30, 2024
@dvdhrm
Copy link
Member

dvdhrm commented Jul 30, 2024

Thank you so much for moving this forward and supplying the tests on top! I included this in the pending roll-up PR #371, and once this lands I will prepare a release.

Again, thanks a lot to all of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering signals by arguments does not work
3 participants