bus/driver: duplicate FDs for queued messages #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new constructor that duplicates the provided FDs and thus takes ownership of the FDs, but does not borrow the FDs of the caller. Signed-off-by: David Rheinsberg <[email protected]>
Duplicate all FDs attached to a message when queuing it for sending. Messages can be queued for arbitrary times, so we cannot rely on borrowed FDs to be available for long enough. Reported-by: Camron Carter <[email protected]> Signed-off-by: David Rheinsberg <[email protected]>
teg
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate FDs for queued messages to ensure they stay around until a message is queued. This fixes a bug where we might try to send messages referencing closed file-descriptors.