Add device attribtues to golden file names

bumptech · Sep 3, 2023 · cbdc1e7 · cbdc1e7
1 parent 3472f80
commit cbdc1e7
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 2 deletions.
diff --git a/integration/compose/build.gradle b/integration/compose/build.gradle
@@ -66,3 +66,28 @@ dependencies {
 }
 
 apply from: "${rootProject.projectDir}/scripts/upload.gradle"
+
+task cleanGoldensOnDevice(type: Exec) {
+ commandLine = ['adb', 'shell', 'rm -rf /storage/emulated/0/DCIM/compose_goldens']
+}
+
+task pullGoldens(type: Exec) {
+ commandLine = [
+ 'bash',
+ '-c',
+ 'adb shell \'find /storage/emulated/0/DCIM/compose_goldens -iname "*.png"\' ' +
+ '| tr -d "\015" ' +
+ '| while read line; do adb pull "$line" src/androidTest/assets/; done'
+ ]
+
+}
+
+afterEvaluate {
+ task rebuildGoldens(type: Exec) {
+ ignoreExitValue = true
+ dependsOn(
+ cleanGoldensOnDevice,
+ tasks.getByName("connectedDebugAndroidTest").finalizedBy(pullGoldens)
+ )
+ }
+}
diff --git a/...ets/glideImage_startsAnimatedDrawable.png → ...Image_startsAnimatedDrawable_2.625_33.png b/...ets/glideImage_startsAnimatedDrawable.png → ...Image_startsAnimatedDrawable_2.625_33.png
diff --git a/...on/compose/src/androidTest/assets/glideImage_startsAnimatedDrawable_2.75_34.png b/...on/compose/src/androidTest/assets/glideImage_startsAnimatedDrawable_2.75_34.png
diff --git a/...rawBehind_drawsImageOnTopOfBackground.png → ..._drawsImageOnTopOfBackground_2.625_33.png b/...rawBehind_drawsImageOnTopOfBackground.png → ..._drawsImageOnTopOfBackground_2.625_33.png
diff --git a/...idTest/assets/glideImage_withDrawBehind_drawsImageOnTopOfBackground_2.75_34.png b/...idTest/assets/glideImage_withDrawBehind_drawsImageOnTopOfBackground_2.75_34.png
diff --git a/...eImage_withPadding_appliesPaddingOnce.png → ...thPadding_appliesPaddingOnce_2.625_33.png b/...eImage_withPadding_appliesPaddingOnce.png → ...thPadding_appliesPaddingOnce_2.625_33.png
diff --git a/...se/src/androidTest/assets/glideImage_withPadding_appliesPaddingOnce_2.75_34.png b/...se/src/androidTest/assets/glideImage_withPadding_appliesPaddingOnce_2.75_34.png
diff --git a/...sition_withPadding_appliesPaddingOnce.png → ...thPadding_appliesPaddingOnce_2.625_33.png b/...sition_withPadding_appliesPaddingOnce.png → ...thPadding_appliesPaddingOnce_2.625_33.png
diff --git a/...droidTest/assets/glideSubcomposition_withPadding_appliesPaddingOnce_2.75_34.png b/...droidTest/assets/glideSubcomposition_withPadding_appliesPaddingOnce_2.75_34.png
diff --git a/integration/compose/src/androidTest/java/com/bumptech/glide/test/goldens.kt b/integration/compose/src/androidTest/java/com/bumptech/glide/test/goldens.kt
@@ -3,6 +3,7 @@ package com.bumptech.glide.test
 import android.content.Context
 import android.graphics.Bitmap
 import android.graphics.BitmapFactory
+import android.os.Build
 import android.os.Environment
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.graphics.ImageBitmap
@@ -19,6 +20,7 @@ import java.lang.IllegalStateException
 
 const val GENERATED_FILES_DIR = "compose_goldens"
 const val EXTENSION = "png"
+const val SEPARATOR = "_"
 
 @Composable
 fun Int.pxToDp() = with(LocalDensity.current) { toDp() }
@@ -68,13 +70,18 @@ private fun readExistingGolden(testName: String): Bitmap? {
  }
 }
 
-private fun testFileName(testName: String) = "$testName.$EXTENSION"
-
+private fun testFileName(testName: String) = "$testName$SEPARATOR${getDeviceString()}.$EXTENSION"
 private fun getTestFilesDir(): File {
  val dir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DCIM)
  return File(dir, GENERATED_FILES_DIR)
 }
 
+private fun getDeviceString() =
+ "${ApplicationProvider.getApplicationContext<Context>()
+ .resources
+ .displayMetrics
+ .density}$SEPARATOR${Build.VERSION.SDK_INT}"
+
 private fun writeBitmap(bitmap: Bitmap, testName: String): String {
  val testFilesDir = getTestFilesDir()
  require(!(!testFilesDir.exists() && !testFilesDir.mkdirs())) { "Failed to make directory: $testFilesDir" }