Fix regressions: Local UI state is not persisted and flickering #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartosdev
approved these changes
Feb 16, 2024
zsoltk
approved these changes
Feb 16, 2024
KovalevAndrey
changed the title
zsoltk
approved these changes
Feb 20, 2024
zsoltk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #671 #672
In this change introduced a bug where I accidentally started saving the state of the transition Box along with children UI state which was wrong. This PR reverts it back and now I only save the state of children UI and not the wrapping Box with transitions.
I checked out the repo in the issue and the bug seems to have gone:
Screen_recording_20240216_171901.mp4
Checklist
CHANGELOG.mdif required.