Fix vault import with different RP IDs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a vault contained multiple credential sources with different RP IDs, only the most recently added source could successfully be used after import. This is because the IdentityVault Import function took the address of a string that resided in the copy created by a range loop. Start address of this copy is always the same for all iterations (iow, range overwrites the previous element copy). We therefore stored the same address &source.RelyingParty multiple times in vault.CredentialSources and eventually virtual-fido behaves as if only the last RP ID was imported. The simple fix is to not use the range copies, but the range index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a vault contained multiple credential sources with different RP IDs, only the most recently added source could successfully be used after import.
This is because the
IdentityVaultImport function took the address of a string that resided in the copy created by a range loop. Start address of this copy is always the same for all iterations (iow, range overwrites the previous element copy). We therefore stored the same address&source.RelyingPartymultiple times invault.CredentialSourcesand eventually virtual-fido behaves as if only the last RP ID was imported.A simple fix is to not use the range copies, but the range index.
Disclaimer: It's my first experience with golang, there may may be better ways to fix this...