Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust assert_text for sign out method in application system test case #1044

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Sep 28, 2023

We were getting a green check when merging #1018, and I'm not sure if something changed along the way, but when signing out we get one of two notifications:

  1. Signed out successfully.
  2. You need to sign in or sign up before continuing

The latter happens when the root is the Team dashboard but the user isn't signed it so the user is redirected to the sign in page (This is our default setup).

The first happens when we use a custom, public page and the user is redirected to a page that doesn't need authentication.

@jagthedrummer jagthedrummer merged commit 6b77006 into main Sep 28, 2023
8 checks passed
@jagthedrummer jagthedrummer deleted the fixes/system-test-logout branch September 28, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants