Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move localforage dependencies from bower to npm #2

Merged
merged 4 commits into from
Apr 20, 2018

Conversation

hbxie
Copy link

@hbxie hbxie commented Apr 19, 2018

Hi, Jeff:

We are migrating bullet-ui to Ember 2.18 and removing all bower dependencies. So we need this change since bullet-ui depends this repo.

Could you take a look? Thank you.

Haibin

@Mogball
Copy link

Mogball commented Apr 20, 2018

@hbxie There's still a bower.json with highlightjs and inuitcss in the project. If this already works for you guys I'll merge and upload a 1.5.8 version today, though.

@hbxie
Copy link
Author

hbxie commented Apr 20, 2018

@Mogball I tested in bullet-ui and it worked so far. Please let me know when 1.5.8 is ready so I can upgrade ours. Thank you.

@Mogball Mogball merged commit 00a1242 into bullet-db:master Apr 20, 2018
@hbxie hbxie deleted the bower branch April 20, 2018 20:57
@Mogball
Copy link

Mogball commented Apr 20, 2018

@hbxie Okay I've pushed out 1.5.8, let me know if there are any issues!

@hbxie
Copy link
Author

hbxie commented Apr 20, 2018

Thanks.

@akshaisarma
Copy link
Member

@Mogball Thanks! Do you also want to merge this into your jeff/localforage branch so it gets into the PR over at funkenstorm/ember-local-storage#278?

@Mogball
Copy link

Mogball commented Apr 22, 2018

Done. That PR has been sitting for a while lol. I'll have some time on my hands now so I might be more active in trying to get that in

@akshaisarma
Copy link
Member

@Mogball Thanks! Yeah, no worries if you can't. This serves our needs well enough already. Also if that PR doesn't go in, if you wanted, you could keep this as a real fork off ember-localstorage, get rid of the storage options since we just need the adapters and publish it as an independent project (which you already do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants