-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new Heroku builder images in the example builders lists #39
base: main
Are you sure you want to change the base?
Conversation
d452916
to
18241fd
Compare
cc @jromero - I think you might be the best person to review given recent the git log (I'm not able to select you as a reviewer via the GitHub reviewers interface since that can only be accessed by users with maintainer access). |
Hi @edmorley I know it is unrelated to your change, but could you update the
|
The `heroku/buildpacks:*` builders have been replaced by `heroku/builder:*` and the former are about to be deprecated. See: https://github.com/heroku/cnb-builder-images/blob/main/README.md buildpacks/pack#1924 Signed-off-by: Ed Morley <[email protected]>
Signed-off-by: Ed Morley <[email protected]>
1eef526
to
571e631
Compare
@jjbustamante Done - could you re-approve the GHA workflow? :-) |
Oh man, this thing is too old. It looks like they moved catlin to its repo now. I tried to run the same commands we are running in the workflow. ➜ tektoncd git clone [email protected]:tektoncd/catlin.git
Cloning into 'catlin'...
warning: templates not found in /Users/juanbustamante/.git_templates
remote: Enumerating objects: 7687, done.
remote: Counting objects: 100% (909/909), done.
remote: Compressing objects: 100% (488/488), done.
remote: Total 7687 (delta 463), reused 755 (delta 386), pack-reused 6778
Receiving objects: 100% (7687/7687), 11.82 MiB | 6.86 MiB/s, done.
Resolving deltas: 100% (3200/3200), done.
Updating files: 100% (3443/3443), done.
➜ tektoncd cd catlin/cmd/catlin
➜ catlin git:(main) go get github.com/tektoncd/catlin/cmd/catlin
go: downloading go.uber.org/zap v1.27.0
... cd catlin/cmd/catlin
go get github.com/tektoncd/catlin/cmd/catlin |
@jjbustamante I think we should just archive this repo at this point, personally :-) |
The
heroku/buildpacks:*
builders have been replaced byheroku/builder:*
and the former are about to be deprecated.See:
https://github.com/heroku/cnb-builder-images/blob/main/README.md
buildpacks/pack#1924