Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Export to OCI format #203

Merged
merged 63 commits into from
Mar 7, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Feb 23, 2022

Resolves #197

Readable

Signed-off-by: Juan Bustamante [email protected]

Note

This RFC was initially proposed as a mechanism for removing the Daemon in the near future, in order to do that, a high level plan I proposed is as follows.

  • Approve this RFC and add the export to OCI layout format feature in Lifecycle
  • Implement in Pack a new workflow when the -daemon flag is enabled based on what we did with the PoC. The workflow could be enabled by the user in experimental mode
    • Make noise in the community so people can help us using it
    • Collect feedback about it
    • Correct issues until we feel confortable
  • Turn off the actual -daemon implementation and replace it with the -oci by default in Pack
    • Maybe we can also add a new flag to re-use the old implementation in case the user needs it
    • Keep doing noise in the community
    • Collect feedback about it
    • Correct issues until we feel confortable
  • Schedule the removal of the Daemon support in Lifecycle version X.Y.Z.
  • Remove the actual daemon support from the code base for Lifecycle version X.Y.Z

I am not 100% we will remove the daemon support, but at least, I want to left this plan here to do not lose it.

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

@jjbustamante jjbustamante changed the title Add Publish operation RFC: Add Publish operation Feb 23, 2022
@jjbustamante jjbustamante changed the title RFC: Add Publish operation RFC: Export to OCI format when Daemon is enabled Mar 2, 2022
@jjbustamante jjbustamante force-pushed the jjbustamante/feature/publish-operation branch 2 times, most recently from 5aa8dbb to d1412b8 Compare March 4, 2022 22:09
@jjbustamante jjbustamante changed the title RFC: Export to OCI format when Daemon is enabled RFC: Export to OCI format Mar 9, 2022
jjbustamante and others added 14 commits February 13, 2023 12:49
Signed-off-by: Juan Bustamante <[email protected]>
Fixes suggested by Natalie

Co-authored-by: Natalie Arellano <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
This reverts commit 9e5c2d0.

Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>

Signed-off-by: Juan Bustamante <[email protected]>
@jjbustamante jjbustamante force-pushed the jjbustamante/feature/publish-operation branch from fda5263 to 1086f45 Compare February 13, 2023 17:51
Fixing error message according to the implementation

Signed-off-by: Juan Bustamante <[email protected]>
@natalieparellano
Copy link
Member

Moving to status/voting closing next Wednesday 2/29

@jjbustamante
Copy link
Member Author

Moving to status/voting closing next Wednesday 2/29

@natalieparellano can we merge this PR?

natalieparellano added a commit that referenced this pull request Mar 7, 2023
[#203]

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano merged commit a221679 into main Mar 7, 2023
@natalieparellano natalieparellano deleted the jjbustamante/feature/publish-operation branch March 7, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Add support for OCI layout / deprecate daemon support
9 participants