-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Export to OCI format #203
Merged
natalieparellano
merged 63 commits into
main
from
jjbustamante/feature/publish-operation
Mar 7, 2023
Merged
RFC: Export to OCI format #203
natalieparellano
merged 63 commits into
main
from
jjbustamante/feature/publish-operation
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintainers, As you review this RFC please queue up issues to be created using the following commands:
Issues(none) |
jromero
reviewed
Feb 24, 2022
jjbustamante
changed the title
RFC: Add Publish operation
RFC: Export to OCI format when Daemon is enabled
Mar 2, 2022
jabrown85
reviewed
Mar 2, 2022
jabrown85
reviewed
Mar 2, 2022
jabrown85
reviewed
Mar 2, 2022
jjbustamante
force-pushed
the
jjbustamante/feature/publish-operation
branch
2 times, most recently
from
March 4, 2022 22:09
5aa8dbb
to
d1412b8
Compare
jjbustamante
changed the title
RFC: Export to OCI format when Daemon is enabled
RFC: Export to OCI format
Mar 9, 2022
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Fixes suggested by Natalie Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
This reverts commit 9e5c2d0. Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]> Signed-off-by: Juan Bustamante <[email protected]>
jjbustamante
force-pushed
the
jjbustamante/feature/publish-operation
branch
from
February 13, 2023 17:51
fda5263
to
1086f45
Compare
4 tasks
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
natalieparellano
approved these changes
Feb 15, 2023
Fixing error message according to the implementation Signed-off-by: Juan Bustamante <[email protected]>
Moving to status/voting closing next Wednesday 2/29 |
@natalieparellano can we merge this PR? |
natalieparellano
added a commit
that referenced
this pull request
Mar 7, 2023
[#203] Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #197
Readable
Signed-off-by: Juan Bustamante [email protected]
Note
This RFC was initially proposed as a mechanism for removing the Daemon in the near future, in order to do that, a high level plan I proposed is as follows.
-daemon
flag is enabled based on what we did with the PoC. The workflow could be enabled by the user in experimental mode-daemon
implementation and replace it with the-oci
by default in PackI am not 100% we will remove the daemon support, but at least, I want to left this plan here to do not lose it.