Move package os to be configured via package.toml
#926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemengo
force-pushed
the
feature/package-buildpack-os-configuration
branch
from
b3ff0d8 to
34f7d8c
Compare
added 2 commits
October 28, 2020 12:06
- unit tests Signed-off-by: Anthony Emengo <[email protected]>
- acceptance tests Signed-off-by: Anthony Emengo <[email protected]>
aemengo
force-pushed
the
feature/package-buildpack-os-configuration
branch
from
34f7d8c to
c3e7e8d
Compare
- Validate only ['linux', 'windows'] is allowed in platform.os of package.toml - Validate correct platform.os for DOCKER_OS Signed-off-by: Anthony Emengo <[email protected]>
micahyoung
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
LGTM. Checks all the boxes for me, based on the Slack conversation: https://buildpacks.slack.com/archives/CD61YAG69/p1603485561046900
jromero
approved these changes
Oct 29, 2020
jromero
added
experimental
jromero
changed the title
os to be configured via package.toml
|
💯 @aemengo. Thanks for driving this through! |
micahyoung
pushed a commit
to micahyoung/pipeline-builder
that referenced
this pull request
Nov 11, 2020
- Pack experimental feature: buildpacks/pack#926 Signed-off-by: Micah Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR is intended as an addendum to #840, which enables
pack package-buildpackfor windows. It removes the recently added--osparameter in favor a platform.os declaration in one'spackage.toml. This new declaration is optional: defaulting to linux when omitted, and thus required for specifying windows. The intention is a more consistent (and backward compatible) user experience.Output
Documentation
Should this change be documented?
[x] Yes, see buildpacks/docs#242
Related
cc: @micahyoung @TisVictress @ameyer-pivotal