Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish #840 #900

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Polish #840 #900

merged 6 commits into from
Oct 20, 2020

Conversation

jromero
Copy link
Member

@jromero jromero commented Oct 20, 2020

This is a polishing PR for original #840 by @TisVictress.

  • The only change was some minor conflict resolution from the latest PR merges to main.

The intent of this PR is solely to provide minor changes to the original in an effort to reduce friction in the review and merging process. As author of the original PR, if there are any questions, comments, or concerns, don't hesitate to reach out to the maintainers.

Anthony Emengo and others added 5 commits October 20, 2020 08:39
Signed-off-by: Anthony Emengo <[email protected]>
Signed-off-by: Andrew Meyer <[email protected]>
Signed-off-by: Victoria Henry <[email protected]>
- Important for publish scenarios to not depend on daemon

Signed-off-by: Micah Young <[email protected]>
@jromero jromero requested a review from a team as a code owner October 20, 2020 19:17
@jromero jromero changed the title Feature/windows package buildpack 172289412 Polish #840 Oct 20, 2020
@jromero jromero added this to the 0.15.0 milestone Oct 20, 2020
@jromero jromero added the type/chore Issue that requests non-user facing changes. label Oct 20, 2020
@jromero jromero merged commit 52eb22c into main Oct 20, 2020
@jromero jromero deleted the feature/windows-package-buildpack-172289412 branch October 20, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant