Removing validation of deprecated io.buildpacks.stack.id #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/enhancement
jjbustamante
reviewed
Dec 4, 2024
| @@ -2181,19 +2185,16 @@ func testAcceptance( | |||
| imageManager.CleanupImages(runImageName) | |||
| }) | |||
|
|
|||
| it("fails with a message", func() { | |||
| it("succeeds with a warning", func() { | |||
There was a problem hiding this comment.
This test is failing when running the acceptance tests because in the previous pack release we were expecting the error message.
--- FAIL: TestAcceptance/acceptance_suite/p_previous_cb_current_lc_current/stack_is_created/builder_is_created/build/builder_is_trusted_(and_set_as_default)/--run-image/the_run_image_has_the_wrong_stack_ID/succeeds_with_a_warning (3.02s)Usually, when a new behavior, we add a Support flag and use SkipIf with previous pack versions to avoid running that test.
In this case, maybe we can do the following:
- Add a new Support flag, valid from versions greater or equal to
0.37.0 - Keep the current test, skip if the version is greater or equal to
0.37.0 - Add the new test and skip it if the version is less than 0.37.0
Signed-off-by: Joey Brown <[email protected]>
Signed-off-by: Joey Brown <[email protected]>
joeybrown
force-pushed
the
stack-warning
branch
from
434ecb7 to
3479ced
Compare
Signed-off-by: Joey Brown <[email protected]>
joeybrown
force-pushed
the
stack-warning
branch
from
7632a24 to
2946153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR picks up where #2119 left off.
Output
Before
After
Related
Resolves #2104