Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP: dont merge] #2109

Draft
wants to merge 82 commits into
base: main
Choose a base branch
from
Draft

[WIP: dont merge] #2109

wants to merge 82 commits into from

Conversation

WYGIN
Copy link
Contributor

@WYGIN WYGIN commented Mar 26, 2024 •
edited by natalieparellano
Loading

Summary

Proof of concept for LFX mentorship: BuildKit explore

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

husni-faiz added 30 commits June 5, 2023 17:56
@husni-faiz
commands: manifest: command to handle manifests
835902d 
Add a new manifest command to pack root commands and add a create
subcommand to the manifest command.

Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
cmd: manifest create: first PoC
ffe1f93 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
cmd: manifest: refactor code
08ec406 
Use source/sinks instead of using primitives directly

Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
cmd: manifest: use ggcr library
9b2a978 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
cmd: manifest: use imgutil
3fc79cc 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: use pack client interface
6b6f2b0 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest_create: separate input validation and manifest creation
e3908c2 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
client: manifest sub command logic function templates
d767b1e 
Function templates for the following manifest sub command logics
- create
- add
- annotate
- push
- remove

Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
commands: manifest sub command templates
3c0b9cc 
Command templates for the following manifest sub commands
- Add
- Annotate
- Push
- Remove

Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
bugfix: manifest: create: use single char for shorthand flag
e9ca7cb 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: create: move flag validations into command logic
3a7c262 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: create: remove path option from remote index:
40eade3 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
create_manifest: raise error if saving the index fails
67d5644 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest_create: add default layout path to save an index
b6b0f0d 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: flag command as experimental
43f97b5 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
client: create an index factory
c3ac0ce 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
create_manifest: use the index factory
1530c23 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: register subcommands
8460b97 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: add annotate subcommand
715e18a 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: add 'add' subcommand
4a478b9 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: use pack home directory to store local manifests
b840b19 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest: return error instead of calling panic
6dee05d 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest add: AppendManifest wrapper function will be removed from im…
ba95ad8 
…gutil

AppendManifest is a wrapper function in imgutil to append a new
manifest to a local index and save it in local storage.
This function will be removed in the future versions of imgutil.

We will use the direct functions to append the manifest and
store the index locally.

Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manfiest: add remove command
0631b34 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest create: remove layout option
605a994 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest add: remove redundent code
bb7902e 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest annotate: update example to use cnbs/sample-package
7be9189 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest create: remove redundant comment
12b1c0f 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest create: simplify the logic for getting the mediatype
1824233 
Signed-off-by: Husni Faiz <[email protected]>
@husni-faiz
manifest command: wrap erros with useful information
0b99d2b 
Signed-off-by: Husni Faiz <[email protected]>
WYGIN added 16 commits March 6, 2024 10:22
@WYGIN
WIP: refactor multi_arch_config
ab1df4e 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP some bp chnages
4e3aa93 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: feat: create image index for #SaveAsImage
1a2bfee 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: added Setters for WorkableImage
c8b35e7 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
chore: generate tests for new changes
0bc2ae8 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
feat: add image to index when creating multiArch buildpacks
6c3d14a 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
chore: add tests for multiArchBP
a30445b 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
fix: few bug fixes
3574670 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
fix: bugs in package_buildpack
776f99d 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: fix bugs; still pack buildpack package has nil pointer bugs
8063906 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
remove debug
be83b01 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: feat added multi-arch for and
1aea687 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: add multi-arch support for Usage:
ac2fd30 
  pack builder create <image-name> --config <builder-config-path> [flags]

Examples:
pack builder create my-builder:bionic --config ./builder.toml

Flags:
  -R, --buildpack-registry string   Buildpack Registry by name
  -c, --config string               Path to builder TOML file (required)
      --flatten stringArray         List of buildpacks to flatten together into a single layer (format: '<buildpack-id>@<buildpack-version>,<buildpack-id>@<buildpack-version>'
  -h, --help                        Help for 'create'
  -l, --label stringToString        Labels to add to the builder image, in the form of '<name>=<value>' (default [])
      --publish                     Publish the builder directly to the container registry specified in <image-name>, instead of the daemon.
      --pull-policy string          Pull policy to use. Accepted values are always, never, and if-not-present. The default is always
  -t, --target strings              Targets are the platforms list to build. one can provide target platforms in format [os][/arch][/variant]:[distroname@osversion@anotherversion];[distroname@osversion]
                                    	- Base case for two different architectures :  '--target "linux/amd64" --target "linux/arm64"'
                                    	- case for distribution version: '--target "windows/amd64:[email protected]"'
                                    	- case for different architecture with distributed versions : '--target "linux/arm/v6:[email protected]"  --target "linux/arm/v6:[email protected]"'

Global Flags:
      --force-color   Force color output
      --no-color      Disable color output
  -q, --quiet         Show less output
      --timestamps    Enable timestamps in output
  -v, --verbose       Show more output

Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: chore upgrade imgutil dependency
536eade 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: minor bug fixes
a129b74 
Signed-off-by: WYGIN <[email protected]>
@WYGIN
WIP: bug fixes for pack builder create
150d28c 
Signed-off-by: WYGIN <[email protected]>
@github-actions github-actions bot added this to the 0.34.0 milestone Mar 26, 2024
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Mar 26, 2024
@natalieparellano
Copy link
Member

(updated the description to link this to the LFX mentorship)

@jjbustamante jjbustamante removed this from the 0.34.0 milestone Apr 3, 2024
@github-actions github-actions bot added this to the 0.34.0 milestone Apr 9, 2024
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Apr 9, 2024
@jjbustamante jjbustamante removed this from the 0.35.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WYGIN @natalieparellano @jjbustamante @husni-faiz @SaikiranIndia