Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a mac-address flag to build option, so that user can manually set the MAC-address. #2028

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Parthiba-Hazra
Copy link
Contributor

Resolves #1779

@Parthiba-Hazra Parthiba-Hazra requested review from a team as code owners January 20, 2024 08:09
@github-actions github-actions bot added this to the 0.33.0 milestone Jan 20, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 20, 2024
…e docker config

Signed-off-by: Parthiba-Hazra <[email protected]>

fix failed workflow

Signed-off-by: Parthiba-Hazra <[email protected]>
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ed450d) 79.64% compared to head (a2573b0) 79.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
+ Coverage   79.64%   79.66%   +0.02%     
==========================================
  Files         176      176              
  Lines       13220    13231      +11     
==========================================
+ Hits        10528    10539      +11     
  Misses       2022     2022              
  Partials      670      670              
Flag Coverage Δ
os_linux 78.59% <100.00%> (+0.05%) ⬆️
os_macos 76.42% <100.00%> (+0.02%) ⬆️
os_windows 79.05% <100.00%> (+0.04%) ⬆️
unit 79.66% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.34.0 Jan 24, 2024
@jjbustamante jjbustamante merged commit f983ad8 into buildpacks:main Feb 8, 2024
18 checks passed
@jjbustamante
Copy link
Member

I am going to revert this PR based on the following:

  • After it was merged, @matejvasek pointed me out that it probably wont work and he created this PR to do some changes
  • I added an acceptance test to check the new flag added, locally it worked but in our CI system we have some constraints summarized in this comment

We will need to wait for the ubuntu runner to update the docker >= 25.0 and we also need to update the windows runner with the same version, Once that is done, I think we can merge again this code + the changes made by @matejvasek and the acceptance test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make specifying a MAC address for the container used for building possible
2 participants