Retrying logic when pulling an image and platform doesn't match #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
jjbustamante
removed
the
type/enhancement
github-actions
bot
added
the
type/enhancement
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1968
branch
from
d00f1a9 to
66da647
Compare
jjbustamante
commented
Nov 9, 2023
jjbustamante
removed
the
type/enhancement
github-actions
bot
added
the
type/enhancement
jjbustamante
removed
the
type/enhancement
jjbustamante
removed
the
type/enhancement
…atch, in this case we will retry without any platform defined (previous behavior) Signed-off-by: Juan Bustamante <[email protected]>
jjbustamante
force-pushed
the
bugfix/jjbustamante/issue-1968
branch
from
119750f to
d022a54
Compare
github-actions
bot
added
the
type/enhancement
jjbustamante
removed
the
type/enhancement
pkg/image/fetcher.go
Outdated
| @@ -192,6 +197,11 @@ func (f *Fetcher) pullImage(ctx context.Context, imageID string, platform string | |||
|
|
|||
| err = jsonmessage.DisplayJSONMessagesStream(rc, &colorizedWriter{writer}, termFd, isTerm, nil) | |||
| if err != nil { | |||
| // sample error from docker engine: | |||
| // image with reference <image> was found but does not match the specified platform: wanted linux/amd64, actual: linux | |||
| if strings.Contains(err.Error(), "does not match the specified platform") { | |||
There was a problem hiding this comment.
Comparing an error string feels a bit fragile.
There was a problem hiding this comment.
I agree... but, the type of error returned is *jsonmessage.JSONError 😕
There was a problem hiding this comment.
The alternative I guess would be to always retry
Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
type/enhancement
Signed-off-by: Natalie Arellano <[email protected]>
|
I added an acceptance test in 5451248 and cleaned up the error wrapping so that we're passing less strings around. I played around with retrying with platform WDYT @jjbustamante @c0d1ngm0nk3y ? |
Great. Because for use, this is issue is quite nasty, so this should help prevent such things in future. |
c0d1ngm0nk3y
approved these changes
Nov 14, 2023
jjbustamante
removed
type/enhancement
jkutner
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Paketo team is trying to create
arm64builders and Buildpacks, but they are doing iteratively, because of that, they are in a situation where they need some mixed support forarm64andamd64users. With the latest pack release 0.32.0 we tried to fix an issue where users running M1 laptops and trying to build aamd64application image ended up with an application image havingamd64code on the top of aarm64run image. see this PRThe problem was, we added a
platformconfiguration (os/arch) when pulling Buildpacks and unfortunately this is not valid because most of the Buildpack ecosystem doesn't specify architecture for their buildpacks.As a consequence, running
pack buildorpack builder createor any command that is pulling Builpacks throws an error, I added a retry logic to pull again, without platform (previous behavior), when an error is found with the messagedoes not match the specified platformOutput
Before
After
packwill silently retrylatest: Pulling from paketo-buildpacks/dotnet-core Digest: sha256:bf28b7631c222794f01e637c2de0d097f39079c0aa6c8fbdaefeef239d404219 Status: Image is up to date for gcr.io/paketo-buildpacks/dotnet-core:latest latest: Pulling from paketo-buildpacks/dotnet-core Digest: sha256:bf28b7631c222794f01e637c2de0d097f39079c0aa6c8fbdaefeef239d404219Documentation
Related
Resolves #1968