Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pack cli support for IBM s390x #1966

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add pack cli support for IBM s390x #1966

merged 2 commits into from
Nov 15, 2023

Conversation

lysliu
Copy link

@lysliu lysliu commented Nov 8, 2023 •
edited
Loading

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1943

@lysliu lysliu requested review from a team as code owners November 8, 2023 14:23
@github-actions github-actions bot added this to the 0.33.0 milestone Nov 8, 2023
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Nov 8, 2023
@jericop
Copy link
Contributor

jericop commented Nov 8, 2023

I assume you will want the pack container images to support s390x as well, so you can add linux/s390x here making it look like this:

--platform linux/amd64,linux/arm64,linux/s390x

@jjbustamante
Copy link
Member

I assume you will want the pack container images to support s390x as well, so you can add linux/s390x here making it look like this:

--platform linux/amd64,linux/arm64,linux/s390x

Thanks @jericop I was actually writing a similar comment 😄

@lysliu
Copy link
Author

lysliu commented Nov 8, 2023

@jericop @jjbustamante thanks both of you! corrected follow your guidance.

@jjbustamante jjbustamante merged commit 2070b50 into buildpacks:main Nov 15, 2023
17 checks passed
@jjbustamante jjbustamante mentioned this pull request Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbustamante jjbustamante jjbustamante approved these changes

Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

Add pack cli support for IBM s390x
3 participants
@lysliu @jericop @jjbustamante