-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pack build
command to export to OCI layout format on disk
#1596
Merged
jkutner
merged 35 commits into
buildpacks:main
from
jjbustamante:enhancement/issue-1548-imagee-in-oci-layout-format
Mar 8, 2023
Merged
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
4d6d39d
WIP - first version
jjbustamante c9e1e0c
WIP - running code formatting
jjbustamante 99ad545
WIP - fixing lint error
jjbustamante c6cef8a
WIP - procesing previous image
jjbustamante a204c11
WIP - fixing linter error
jjbustamante edc2bde
WIP - I removed the layout-repo volume and now every input (run-image…
jjbustamante 7e5829e
WIP - Pointing to the imgutil version with name.ref annotation
jjbustamante abc51fe
WIP - fixing linting error
jjbustamante 114e8b1
WIP - Pointing to the imgutil version with name.ref annotation
jjbustamante 87cc8d3
WIP - tagging the image
jjbustamante 256b0dc
root path for win or linux
jjbustamante 4fe9225
adding layout-dir flag according to latest change in the lifecycle
jjbustamante 8f83efc
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante 1185676
fixing lint error
jjbustamante 79c7e54
adding unit test coverage for lifecycle_execution.go
jjbustamante 64ea6b7
adding test coverage for build.go
jjbustamante 70c5416
adding test coverage to the configuration files
jjbustamante d21e0c8
adding test coverage for input image reference
jjbustamante d3a9532
adding coverage for fetcher
jjbustamante fe63a00
adding test coverage for build
jjbustamante ead6d12
renaming some variables as it was before
jjbustamante 2c636a7
fixing validation on previous image
jjbustamante 6918797
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jkutner 8cfab73
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante 3c1a801
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante a3aa7fd
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante 7761d79
Fixing broken tests
jjbustamante 4bca03f
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante d2f1615
adding support for platform 0.11 and 0.12, fixing acceptance tests
jjbustamante 18e758c
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante 5a02b07
Fixing test on windows
jjbustamante e038d46
Format issue
jjbustamante 4f8cc8a
Merge branch 'main' into enhancement/issue-1548-imagee-in-oci-layout-…
jjbustamante 12c370a
fixing windows tests, some of the tests are skip for now
jjbustamante fd9dc9e
fixing issue on windows
jjbustamante File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
//go:build linux || darwin | ||
// +build linux darwin | ||
|
||
package paths | ||
|
||
const ( | ||
RootDir = `/` | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a little odd to me. Are we sure we want the default layout dir in the config dir?
Also, it looks like this isn't actually configurable right? It's either the default or nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for now, because the feature is experimental, I didn't want to do a lot of work giving the user a configuration option. basically, the idea is:
run-image
on disk, maybe the user doesn't care, that's why I am saving them in the pack home directoryThe other alternative is, I could work on the user experience for configuring and customizing this kind of thing, but, I was planing to do it after shipping at least something the users can play with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I can see pack already save some data in the same folder, for example.
Those
registry-*
folders are already saving data thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just metadata that goes in this dir? Or does it actually store large files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will save the
run-image
in OCI layout format, it could have all the blobs depending on whether the user set thesparse
flag or not. But it could have large files, for sure