-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Update getFileFilter
to include parent folders
#1439
base: main
Are you sure you want to change the base?
Conversation
48a493d
to
a76e5f8
Compare
The PR focuses on |
a76e5f8
to
e4081d0
Compare
e7f0b86
to
ab66f6b
Compare
ab66f6b
to
55e3f0e
Compare
- The `include` directive when specified with a file inside a folder `testdir/testfile` did not pass the parent folder to the builder image, which led to the folder being created by docker instead pack causing the permissions of the folder to be `cnb`. - This PR fixes the include logic to get parent folders and add them to the file filter, so they get created via pack. Signed-off-by: Nitish Gupta <[email protected]>
55e3f0e
to
c1af702
Compare
Hey @jromero, |
Summary
include
directive when specified with a file inside afolder
testdir/testfile
did not pass the parent folder tothe builder image, which led to the folder being created by
docker instead pack causing the permissions of the folder
to be
cnb
.add them to the file filter, so they get created via pack.
Output
Before
After
Documentation
Related
Resolves #1419