Add buildpack name to buildpack and builder metadata

[sambhav]

Signed-off-by: Sambhav Kothari [email protected]

Summary

Adds the name to buildpackage, builder and build layers

Notes -

I ended up having to change some acceptance manager logic to get the previous builder tests to pass. New releases of pack include the build number and the git commit in the version which was causing the override files to not work as expected. As a result I had to add a sanitizer to the version string and use that for overrides. The large number of lines changed is due to the 0.18 builder outputs.

Output

Before

$ git clone https://github.com/buildpacks/samples
$ cd buildpacks/hello-world
$ pack buildpack package sample-before
$ pack inspect-buildpack sample-before
Inspecting buildpack: sample-before
LOCAL IMAGE:

Stacks:
  ID: io.buildpacks.samples.stacks.bionic
    Mixins:
      (omitted)
  ID: io.buildpacks.samples.stacks.alpine
    Mixins:
      (omitted)
  ID: io.buildpacks.stacks.bionic
    Mixins:
      (omitted)

Buildpacks:
  ID                         VERSION        HOMEPAGE
  samples/hello-world        0.0.1          https://github.com/buildpacks/samples/tree/main/buildpacks/hello-world

Detection Order:
 └ Group #1:

After

$ git clone https://github.com/buildpacks/samples
$ cd buildpacks/hello-world
$ pack buildpack package sample-after
$ pack inspect-buildpack sample-after 
Inspecting buildpack: sample-after

LOCAL IMAGE:

Stacks:
  ID: io.buildpacks.samples.stacks.bionic
    Mixins:
      (omitted)
  ID: io.buildpacks.samples.stacks.alpine
    Mixins:
      (omitted)
  ID: io.buildpacks.stacks.bionic
    Mixins:
      (omitted)

Buildpacks:
  ID                         NAME                         VERSION        HOMEPAGE
  samples/hello-world        Hello World Buildpack        0.0.1          https://github.com/buildpacks/samples/tree/main/buildpacks/hello-world

Detection Order:
 └ Group #1:
    └ samples/[email protected]    

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #994

[dfreilich]

This is 🏅 . The percentage of LOC changed to test files changed is wild, and is definitely food for thought. Thanks for taking this all the way!

[codecov]

Codecov Report

Merging #1119 (5e5d167) into main (d2d29c1) will increase coverage by 0.15%.
The diff coverage is 66.67%.

@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
+ Coverage   80.55%   80.70%   +0.15%     
==========================================
  Files         136      136              
  Lines        8257     8259       +2     
==========================================
+ Hits         6651     6665      +14     
+ Misses       1176     1164      -12     
  Partials      430      430              

Flag	Coverage Δ
os_linux	80.14% <66.67%> (+0.11%)	⬆️
os_macos	77.71% <66.67%> (+0.16%)	⬆️
os_windows	80.62% <66.67%> (+0.16%)	⬆️
unit	80.19% <66.67%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.