Skip to content

Commit

Permalink
Merge pull request #302 from buildpack/fix-create-builder-unit-winodws
Browse files Browse the repository at this point in the history
Enable create-builder unit tests on windows w/o docker
  • Loading branch information
ekcasey authored Sep 13, 2019
2 parents 588bfde + a666679 commit 90e88e7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 2 additions & 0 deletions build/testdata/fake-lifecycle/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ require (
golang.org/x/net v0.0.0-20190206173232-65e2d4e15006 // indirect
golang.org/x/sys v0.0.0-20190204203706-41f3e6584952 // indirect
)

go 1.13
7 changes: 4 additions & 3 deletions create_builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
)

func TestCreateBuilder(t *testing.T) {
h.RequireDocker(t)
color.NoColor = true
spec.Run(t, "create_builder", testCreateBuilder, spec.Parallel(), spec.Report(report.Terminal{}))
}
Expand Down Expand Up @@ -295,10 +294,12 @@ func testCreateBuilder(t *testing.T, when spec.G, it spec.S) {
})

it("disallows directory-based buildpacks", func() {
opts.BuilderConfig.Buildpacks[0].URI = "some/buildpack/dir"
opts.BuilderConfig.Buildpacks[0].URI = "testdata/buildpack"

err := subject.CreateBuilder(context.TODO(), opts)
h.AssertError(t, err, "buildpack 'bp.one': directory-based buildpacks are not currently supported on Windows")
h.AssertError(t,
err,
"buildpack 'testdata/buildpack': directory-based buildpacks are not currently supported on Windows")
})
})

Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ require (
github.com/spf13/pflag v1.0.3 // indirect
golang.org/x/tools v0.0.0-20190425150028-36563e24a262
)

go 1.13

0 comments on commit 90e88e7

Please sign in to comment.