Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover corrupted volume cache #1410

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Recover corrupted volume cache #1410

merged 4 commits into from
Oct 24, 2024

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Oct 22, 2024

Summary

This builds upon the work of @joeybrown-sf in #1381 / buildpacks/lifecycle-private#16 by skipping restore & cache re-use for layers whose contents do not match their declared sha.

Release notes

The lifecycle skips restore & cache re-use for (cache volume) layers whose contents do not match their declared sha


Related

Resolves #1407


Context

Make sure to hide whitespace when viewing the diff, because I cleaned up some test nesting

cache/volume_cache.go Outdated Show resolved Hide resolved
@natalieparellano natalieparellano force-pushed the restore-checks-sha branch 2 times, most recently from 3cf82c4 to d0ccbee Compare October 23, 2024 19:23
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano marked this pull request as ready for review October 23, 2024 21:04
@natalieparellano natalieparellano requested a review from a team as a code owner October 23, 2024 21:04
@natalieparellano natalieparellano merged commit 4d5a1b4 into main Oct 24, 2024
8 checks passed
@natalieparellano natalieparellano deleted the restore-checks-sha branch October 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter should invalidate the cache if it fails to write it
3 participants