Do not obscure error message #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
approved these changes
Oct 27, 2023
|
Aye, now the linter is unhappy because the spacing for our exported message vars has changed and they were uncommented. You could update the commit sha here: Line 38 in 367b451 |
Signed-off-by: Ralf Pannemans <[email protected]>
c0d1ngm0nk3y
force-pushed
the
do-no-hide-error
branch
from
d8d73ae to
0acf432
Compare
I have made some changes. IMHO, not the most useful linter warning though :) Please have a look. |
natalieparellano
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the lifecycle failed because there was no readable run image, the error was rather misleading:
-run-image is required when there is no stack metadata availableThis was caused by hiding the underlying error.
Release notes
Improve error message in case run-image is not readable.
Related
Resolves #___
Context
When the run image is on a protected registry, the
authdata must be provided to the lifecycle.