Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in Dependabot config #226

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Oct 27, 2023

The groups section added in #223 was indented incorrectly, resulting in Dependabot ignoring the groups section of the config.

It's not clear why the Dependabot config schema validation didn't highlight the error on the PR - perhaps because it doesn't run on forked PRs?

The `groups` section added in buildpacks#223 was indented incorrectly,
resulting in Dependabot ignoring the config.

It's not clear why the Dependabot config schema validation didn't
highlight the error on the PR - perhaps because it doesn't run on
forked PRs?

Signed-off-by: Ed Morley <[email protected]>
@edmorley edmorley requested a review from a team as a code owner October 27, 2023 19:53
@edmorley
Copy link
Contributor Author

@natalieparellano Apologies for missing this in the original PR. I've checked all of my other unmerged Dependabot update PRs and they don't have the same issue.

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @edmorley!

@natalieparellano natalieparellano merged commit 0eae658 into buildpacks:main Oct 27, 2023
3 checks passed
@edmorley edmorley deleted the fix-dependabot-config branch October 27, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants