Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for new [[build.env]] table in builder.toml #622

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Docs for new [[build.env]] table in builder.toml #622

merged 4 commits into from
Nov 3, 2023

Conversation

WYGIN
Copy link
Contributor

@WYGIN WYGIN commented Oct 25, 2023

this will add docs for the pr buildpacks/pack#1926

@WYGIN
added docs for new build.env table
ff52920 
Signed-off-by: Sai Kiran Maggidi <[email protected]>
@WYGIN WYGIN requested a review from a team as a code owner October 25, 2023 16:12
@WYGIN WYGIN mentioned this pull request Oct 25, 2023
Merged
2 tasks
AidanDelaney
AidanDelaney approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The build failures are not a consequence of this change. I'll get those fixed and then we can merge this.

natalieparellano
natalieparellano reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome :) I made a few suggestions for readability.

content/docs/reference/config/builder-config.md Outdated Show resolved Hide resolved
content/docs/reference/config/builder-config.md Outdated Show resolved Hide resolved
content/docs/reference/config/builder-config.md Outdated Show resolved Hide resolved
@WYGIN
improve readability
16c3a42 
Signed-off-by: WYGIN <[email protected]>
@AidanDelaney AidanDelaney merged commit ca372a4 into buildpacks:main Nov 3, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
@AidanDelaney
Merge pull request #622 from WYGIN/build-config-env
6a34f8c 
Docs for new [[build.env]] table in builder.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieparellano natalieparellano natalieparellano approved these changes

@AidanDelaney AidanDelaney AidanDelaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WYGIN @AidanDelaney @natalieparellano