Skip to content

Commit

Permalink
Remove uses of with_indifferent_access
Browse files Browse the repository at this point in the history
The tests are fine without them.
  • Loading branch information
pat committed Feb 15, 2024
1 parent 79fa893 commit d3246b9
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion lib/buildkite/test_collector.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ module TestCollector
require "timeout"
require "tmpdir"

require "active_support/core_ext/hash/indifferent_access"
require "active_support/notifications"

require_relative "test_collector/version"
Expand Down
2 changes: 1 addition & 1 deletion lib/buildkite/test_collector/minitest_plugin/trace.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def as_hash
failure_reason: failure_reason,
failure_expanded: failure_expanded,
history: history,
).with_indifferent_access.select { |_, value| !value.nil? }
).select { |_, value| !value.nil? }
end

private
Expand Down
2 changes: 1 addition & 1 deletion lib/buildkite/test_collector/rspec_plugin/trace.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def as_hash
failure_reason: failure_reason,
failure_expanded: failure_expanded,
history: history,
).with_indifferent_access.select { |_, value| !value.nil? }
).select { |_, value| !value.nil? }
end

private
Expand Down
2 changes: 1 addition & 1 deletion lib/buildkite/test_collector/tracer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def as_hash
duration: end_at - start_at,
detail: detail,
children: children.map(&:as_hash),
}.with_indifferent_access
}
end
end

Expand Down

0 comments on commit d3246b9

Please sign in to comment.