Skip to content

Commit

Permalink
Merge pull request #139 from buildkite/revert-130-PIE-929/run-prefix-…
Browse files Browse the repository at this point in the history
…suffix

Revert "Allow specifying run name prefix and suffix"
  • Loading branch information
JuanitoFatas authored Jul 12, 2022
2 parents 45bab4c + bd9d86f commit c6ae2c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
4 changes: 1 addition & 3 deletions lib/buildkite/test_collector/ci.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ def analytics_env
"debug" => ENV["BUILDKITE_ANALYTICS_DEBUG_ENABLED"],
"version" => Buildkite::TestCollector::VERSION,
"collector" => Buildkite::TestCollector::NAME,
"run_name_prefix" => ENV["BUILDKITE_ANALYTICS_RUN_NAME_PREFIX"],
"run_name_suffix" => ENV["BUILDKITE_ANALYTICS_RUN_NAME_SUFFIX"],
}.compact
}.compact
end

def generic
Expand Down
6 changes: 1 addition & 5 deletions spec/test_collector/ci_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,6 @@
fake_env("BUILDKITE_ANALYTICS_NUMBER", number)
fake_env("BUILDKITE_ANALYTICS_JOB_ID", job_id)
fake_env("BUILDKITE_ANALYTICS_MESSAGE", message)
fake_env("BUILDKITE_ANALYTICS_RUN_NAME_PREFIX", "run_name_prefix")
fake_env("BUILDKITE_ANALYTICS_RUN_NAME_SUFFIX", "run_name_suffix")
end

it "returns the analytics env" do
Expand All @@ -271,9 +269,7 @@
"message" => message,
"debug" => debug,
"version" => version,
"collector" => name,
"run_name_prefix" => "run_name_prefix",
"run_name_suffix" => "run_name_suffix",
"collector" => name
})
end
end
Expand Down

0 comments on commit c6ae2c4

Please sign in to comment.