Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: niceking <[email protected]>
  • Loading branch information
nprizal and niceking authored Jun 1, 2023
1 parent 2e08b73 commit 2c34694
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ git push origin add-buildkite-test-analytics
```

### VCR
If your test suites use [VCR](https://github.com/vcr/vcr) to interact with HTTP, you need to allow them to make an actual request to Test Analytics.
If your test suites use [VCR](https://github.com/vcr/vcr) to stub network requests, you'll need to modify the config to allow actual network requests to Test Analytics.

```
VCR.configure do |c|
Expand Down
2 changes: 1 addition & 1 deletion lib/buildkite/test_collector/uploader.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ def self.upload(data)
retry
end
rescue StandardError => e
$stderr.puts "#{Buildkite::TestCollector::NAME} #{Buildkite::TestCollector::VERSION} experienced an error when sending your data, you may be missing some executions for this run."
$stderr.puts e
$stderr.puts "#{Buildkite::TestCollector::NAME} #{Buildkite::TestCollector::VERSION} experienced an error when sending your data, you may be missing some executions for this run."
end
end
end
Expand Down

0 comments on commit 2c34694

Please sign in to comment.