Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto upload android symbols #856

Open
wants to merge 9 commits into
base: integration/auto-symbol-upload
Choose a base branch
from

Conversation

richardelms
Copy link
Contributor

@richardelms richardelms commented Nov 19, 2024

Goal

  • auto upload android symbols on build
  • enable configuration of auto uploads

Changeset

  • added new build time config values:
    • bool AutoUploadSymbols;
    • string BugsnagCLIExecutablePath;
    • string UploadEndpoint;
  • added new config values to the config window.
  • added toggle menu item to quickly enable/disable auto upload.
  • added BugsnagAndroidSymbolUploader.cs
  • ensured all bugsnag editor tools are within the Bugsnag.Editor namespace.
image

image

Testing

E2E testing will be added in a later PR to the integration branch

@richardelms richardelms self-assigned this Nov 19, 2024
@richardelms richardelms marked this pull request as ready for review November 19, 2024 10:17
public class AutoSymbolUploadToggleMenu
{

[MenuItem("Window/BugSnag/Auto Upload Symbols")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the screenshot, I suggest we should have:

Configuration
--
Enable symbol uploads
Enable EDM4U support

@bugsnagbot
Copy link
Collaborator

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2602.37
IL2CPP IPA 1696.63

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants