Add any successfully parsed non-nil JSON body to report, regardless of class #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The purpose of this PR is to allow any successfully parsed JSON body to be displayed in the request tab of the event page. Previously, only Hashes were included in the event report, which meant that any errors that occurred during the processing of a request with content type
application/json-patch+json
(where the top level element is an array) did not have enough information to debug the issue.Design
N/A
Changeset
Before this change, only JSON that was parsed to a non-empty Hash was added to the
$request.body
event metadata. After this change, any successfully parsed non-nil object will be added.Testing
I have not updated the tests, as
add_request_body
, and this did not seem like a good tradeoff in terms of test maintainability.Having said that, if it is requested, I will add a new test - it would probably be a unit test that did a naughty test of the private
add_request_body
method only.