Merge pull request #124 from bugsnag/dedupe-logging

Prevent duplicate log for undelivered error, fixes #123
bugsnag · Jan 8, 2018 · ff5dfbc · ff5dfbc
2 parents 7f4ee1c + 163a307
commit ff5dfbc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/bugsnag.js b/lib/bugsnag.js
@@ -66,8 +66,12 @@ function autoNotifyCallback(notifiedError, uncaughtError) {
                     errorMsg.push("configuration options prevent the following error from being sent to Bugsnag.");
                     errorMsg.push("https://docs.bugsnag.com/platforms/nodejs/other/configuration-options/#notifyreleasestages");
                 }
-                errorMsg.push("");
-                errorMsg.push(notifiedError.stack);
+                // only print caught errors at this point. uncaught errors get printed by
+                // the onUncaughtError function later so this prevents duplicate logs
+                if (!(Configuration.onUncaughtError && uncaughtError)) {
+                  errorMsg.push("");
+                  errorMsg.push(notifiedError.stack);
+                }
             }
             errorMsg.push("");
             Configuration.logger.error(errorMsg.join('\n'));