Merge pull request #137 from bugsnag/better-logging

Improve logging clarity for unhandled exceptions
bugsnag · Mar 8, 2018 · ac3b195 · ac3b195
2 parents e56a87d + c96e7a2
commit ac3b195
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/bugsnag.js b/lib/bugsnag.js
@@ -73,7 +73,6 @@ function autoNotifyCallback(notifiedError, uncaughtError) {
                   errorMsg.push(notifiedError.stack);
                 }
             }
-            errorMsg.push("");
             Configuration.logger.error(errorMsg.join('\n'));
         }
         if (Configuration.onUncaughtError && uncaughtError) {

diff --git a/lib/configuration.js b/lib/configuration.js
@@ -32,11 +32,16 @@ var Configuration = {
     onUncaughtError: function(err) {
         if ((err instanceof Error) && err.domain) {
             if (err.domainThrown || err.domainEmitter || err.domainThrown === void 0) {
-            Configuration.logger.error(err.stack || err);
-            return process.exit(1);
+                var context = "";
+                if (err.domain._bugsnagOptions && err.domain._bugsnagOptions.cleanedRequest) {
+                    context += " at " + err.domain._bugsnagOptions.cleanedRequest.httpMethod
+                    context += " " + err.domain._bugsnagOptions.cleanedRequest.path + ""
+                }
+                Configuration.logger.error("Encountered an uncaught error" + context + " terminating…\n" + (err.stack || err));
+                return process.exit(1);
             }
         } else {
-            Configuration.logger.error(err.stack || err);
+            Configuration.logger.error("Encountered an uncaught error, terminating…\n" + (err.stack || err));
             return process.exit(1);
         }
     },