run e2e tests over https #2253
Open
run e2e tests over https #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
commented
Nov 15, 2024
Comment on lines
+172
to
+174
| # | ||
| # BrowserStack non-https tests | ||
| # |
There was a problem hiding this comment.
not sure if there's a DRYer way of doing this rather than duplicating most of the previous section? A parameterized matrix, perhaps?
There was a problem hiding this comment.
I don't think so unfortunately, the Buildkite YAML schema is quite limited when it comes to any kind of commonality or logic between steps.
twometresteve
approved these changes
Nov 15, 2024
Comment on lines
+172
to
+174
| # | ||
| # BrowserStack non-https tests | ||
| # |
There was a problem hiding this comment.
I don't think so unfortunately, the Buildkite YAML schema is quite limited when it comes to any kind of commonality or logic between steps.
There was a problem hiding this comment.
We're just removing Gemfile.locks from Git these days to reduce dependabot warnings - but you could just do that on your next PR to avoid another build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Get the browser e2e tests running over https so we can test functionality that requires a secure context.
Design/Changeset
/docsTesting
e2e tests passing locally and on CI