Startup timeout fixes #2080
Merged
Startup timeout fixes #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
approved these changes
Sep 27, 2024
…livery to handle cases where the app start has completed before Bugsnag.start is called
lemnik
force-pushed
the
lemnik/startup-timeout-fixes
branch
from
0657980
to
971af4f
Compare
Android notifier sizes
Generated by 🚫 Danger |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Use a reasonable timeout for startup crash delivery in cases when
Bugsnag.startis called long after the app start.Changeset
If the startup crash synchronous timeout would be
<=0we revert to the old behavior and block for up-to a full 2 seconds.Testing
Relied on the existing tests being more reliable.