Handle large buffers in file::read

bugdea1er · Jan 1, 2025 · 608c13c · 608c13c
1 parent bb6aa76
commit 608c13c
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/file.cpp b/src/file.cpp
@@ -111,12 +111,9 @@ std::string file::read() const {
 
   std::size_t offset = 0;
   while (offset < content.size()) {
-    // FIXME: handle large buffers
-#ifdef _WIN32
-    int bytes_read = _read(handle, &content[offset], content.size() - offset);
-#else
-    ssize_t bytes_read = ::read(handle, &content[offset], content.size() - offset);
-#endif
+    // `read` will fail if the parameter `nbyte` exceeds `INT_MAX`
+    int nbyte = static_cast<int>(std::min<size_t>(content.size() - offset, INT_MAX));
+    auto bytes_read = ::read(handle, &content[offset], nbyte);
 
     if (bytes_read == 0) {
       break;