Build & push demo binaries on main #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also attempts building on PRs for testing.
rubensf
force-pushed
the
rfarias/build-push-docker
branch
from
4d778b1
to
b5b4a37
Compare
DMarby
reviewed
Oct 3, 2024
.github/workflows/docker.yaml
Outdated
Comment on lines
58
to
59
| ${{ env.REGISTRY_URL }}/bufstream-demo:git.${{ github.sha }} | ||
| ${{ env.REGISTRY_URL }}/bufstream-demo:latest |
There was a problem hiding this comment.
Since we're building multiple dockerfiles, probably need the tag to at least be partially based on matrix.dockerfile as well?
There was a problem hiding this comment.
image testing - fixed, thanks
DMarby
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also attempts building on PRs for testing.