Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTK4 support #38

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add GTK4 support #38

wants to merge 2 commits into from

Conversation

btzy
Copy link
Owner

@btzy btzy commented Apr 23, 2021

This PR is for (experimental) GTK4 support. Resolves #24.

As this backend is experimental, GTK3 remains as the default backend. Use -DNFD_GTK_VERSION=4 to activate this new backend.

Blocking issues:

  • The "Save" button in the dialog is sometimes disabled if the user does not click on an item in the file/directory list. This doesn't make sense in the context of a file save dialog though - it shouldn't be necessary to select something in the list, if the user types something into the text box. This is important but I'm not sure how to fix it - help wanted.
  • SaveDialog has "pressed"/"button-press-event" signals that need to be replaced with gestures. In progress, but doesn't work yet.

Other unresolved issues (non-blocking):

  • X11 pop-under issue not yet applied to GTK4.
  • Downloading a non-local file might take a while, but it is impossible to cancel. On Windows, the file is downloaded while the dialog is still open (this is automatically done by the file dialog), so the user can cancel it.
  • There is a warning about the lack of transient parent for all dialogs, and the dialog is not modal; this is probably unresolvable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTK4 Support
1 participant