Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private PYPI upload + dynamic versioning #87

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Private PYPI upload + dynamic versioning #87

wants to merge 11 commits into from

Conversation

giampaolo
Copy link
Contributor

  • adds dynamic versioning based on git commit + git hash
  • adds make priv-pypi-upload target

Ryanb58
Ryanb58 suggested changes Jan 22, 2018
View reviewed changes
Makefile Outdated
TEST_PREFIX = PYTHONWARNINGS=all FULLTEXT_TESTING=1
PASSWORD =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Veristack/duster/pull/93/files#r162948630

btimby
btimby approved these changes Mar 22, 2018
View reviewed changes
Copy link
Owner

@btimby btimby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giampaolo
Copy link
Contributor Author

We better use versioneer lib to do this. Keeping it open as a WIP for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryanb58 Ryanb58 Ryanb58 requested changes

@btimby btimby btimby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giampaolo @btimby @Ryanb58