refactor: mergeSingleChildTrees #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btd
reviewed
Dec 9, 2023
| } else { | ||
| return node; | ||
| const leaf: ModuleTreeLeaf = { name, uid: child.uid }; | ||
| return leaf; |
There was a problem hiding this comment.
This one not correct. We modify tree in place. But this branch will cut it completly
btd
reviewed
Dec 9, 2023
|
|
||
| while (stack.length > 0) { | ||
| const current = stack.pop(); | ||
|
|
There was a problem hiding this comment.
Add if(!current) break, instead of repeating it in both conditions
|
This seems not correct to me. I do not remember if there are unit tests for this. But i suggest to add them first to check that your implementation does not change behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO solved: try to make it without recursion, but still typesafe
Advantages of the iterative approach with a stack:
Avoiding potential stack overflow: Using an explicit stack allows you to control and manage the memory usage more efficiently, reducing the risk of a stack overflow, especially for deep trees.
Improved performance: Iterative approaches often have better performance characteristics compared to recursive solutions, as they avoid the overhead of function calls and stack management.
I hope this is helpful for you, and I look forward to your review. :)