Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Open RTB 2.6 added support for a new language specification (IETF BCP 47) on
BidRequest
,Device
, andContent
objects in the form of an alternate language field calledwlangb
orlangb
. A recently merged PR addedlangb
to theContent
obj. This PR fully incorporates the new language fields, allowing for complete OpenRTB 2.6 support of all language fields in all associated objects.BidRequest
wlangb []string
Device
langb string
Content
langb string
Note, aside from simply adding the fields, I've put the 2 lang fields near each other in the respective files. Also moved
cattax
to be nearcat
since they are also tightly coupled. Lastly, I made sure the comments were word for word what's in the OpenRTB 2.6 spec, as I felt some important information was left out.Additional Context from OpenRTB 2.6
Would like to request a new minor release after merging.