Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full support for langb fields #109

Merged
merged 6 commits into from
Aug 21, 2023
Merged

full support for langb fields #109

merged 6 commits into from
Aug 21, 2023

Conversation

codenaugh
Copy link
Contributor

@codenaugh codenaugh commented Aug 8, 2023

Summary

Open RTB 2.6 added support for a new language specification (IETF BCP 47) on BidRequest, Device, and Content objects in the form of an alternate language field called wlangb or langb. A recently merged PR added langb to the Content obj. This PR fully incorporates the new language fields, allowing for complete OpenRTB 2.6 support of all language fields in all associated objects.

BidRequest

wlangb []string

Device

langb string

Content

langb string

Note, aside from simply adding the fields, I've put the 2 lang fields near each other in the respective files. Also moved cattax to be near cat since they are also tightly coupled. Lastly, I made sure the comments were word for word what's in the OpenRTB 2.6 spec, as I felt some important information was left out.

Additional Context from OpenRTB 2.6

Added new language field to support IETF BCP 47
IETF BCP 47 offers additional layers of granularity, for example, differentiating written language
versions of the same spoken language (e.g. Traditional and Simplified Chinese)
https://en.wikipedia.org/wiki/IETF_language_tag

Would like to request a new minor release after merging.

- update comment for `langb` to reflect what's in the ORTB 2.6 spec
- move `cattax` and `langb` fields to be in more relevant positions
- added `langb` field, since it was recently added to the `Content` object
- Add `wlangb` field
More explicit, descriptive, and consistent field names for `langb`
More explicit, descriptive, and consistent field names for `langb`
More explicit, descriptive, and consistent field names for `langb`
content.go Show resolved Hide resolved
device.go Show resolved Hide resolved
@codenaugh codenaugh requested a review from dim August 17, 2023 15:44
@dim dim merged commit 5563255 into bsm:main Aug 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants