iNToRecFN num_zero_o fix width #11
Conversation
|
Should we merge this? |
|
What's the issue and resolution? |
|
This fixes a regression caused by #9. If you use the current master of HardFloat, you get this width mismatch error: because bsg_counting_leading_zeros uses `BSG_WIDTH for the output where Hardfloat uses different widths for different contexts of CLZ: see: #10. This PR fixes the width mismatch for iNtoRecFN, allowing synthesis to proceed |
|
@stdavids Can you confirm that this fix looks correct, based on the other github issue discussion? |
|
Can you please merge with bespoke-silicon-group/bsg_manycore#608? For int32 to float, you need 6-bits to represent the number of leading zeros, but you don't need to know if the input is 32'b0, in which case it will fall into the zero category anyway. |
|
This doesn't resolve #10 where the primary issue was that the semantics of the original countLeadingZeros and the bsg_priority_encode substitutes are different. It was mentioned, however, in #10 that there were some width mismatch issues in iNToRecFN and mulAddRecFN -- this PR does address the width mismatch issue in iNToRecFN and appears correct. |
|
Okay so how do we converge?
…On Thu, Jan 6, 2022 at 2:52 PM Scott Davidson ***@***.***> wrote:
This doesn't resolve #10
<#10> where the primary
issue was that the semantics of the original countLeadingZeros and the
bsg_priority_encode substitutes are different. It was mentioned, however,
in #10 <#10> that there
were some width mismatch issues in iNToRecFN and mulAddRecFN -- this PR
does address the width mismatch issue in iNToRecFN and appears correct.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFG5AA3Q2S5X6F6DOVXJRTUUYML3ANCNFSM5IUY35FQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
The first step would be to merge this. I haven't seen any problems with mulAddRecFN |
Fix synth issue:
Error: Width mismatch on port 'num_zero_o' of reference to 'bsg_counting_leading_zeros' in 'iNToRawFN_intWidth32'. (LINK-3)
Error: Unable to match ports of cell proc/h.z/vcore/fpu_float0/aux0/i2f/iNToRawFN/clz ('bsg_counting_leading_zeros') to 'bsg_counting_leading_zeros_width_p32'. (LINK-25)